Fix Silabs HAL: also send commands to group bindings - #437
Conversation
|
@romasku @andrei-lazarov should I update firmware version right now, or CI will do it after merge? |
|
This looks like a big omission, how hasn't anyone reported yet? 😯 Thanks for fixing Not sure what to do while romasku is inactive.. I don't want to update source code and release without him Also I've removed the image metadata (location) for your privacy... |
|
I'm just playing around with a few devices and trying to make my smart home work exactly the way I want. Native Zigbee bindings are always better than integrations through HA, so I'm using them everywhere it's possible =) A big update with support for a separate long-press endpoint is almost here, but one of my (battery) devices suddenly dropped off the network, so I'm doing some field testing before publishing the PR. Thanks for the metadata, I wasn't worried about it. |
|
Hey I built your PR and binding to group works now. Thank you! |
|
Great catch, thank you! |
4 participants
Discovered on Moes ZT-B-EU2 (TS0042) that buttons bound to a Zigbee group emit nothing on press, while unicast bindings work fine.
Turns out
hal_zigbee_send_cmd_to_bindings()only callssl_zigbee_af_send_command_unicast_to_bindings()— group entries havebinding.type == SL_ZIGBEE_MULTICAST_BINDINGand get filtered out by the unicast walk. The SiLabs framework itself handles this by calling both_unicast_to_bindings()and_multicast_to_bindings()back-to-back after a singlefill_external_buffer(seereporting.c:367-381) — mirrored here.